Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add redirect for blank route #5439

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

kieckhafer
Copy link
Member

Impact: minor
Type: chore

Issue

localhost:3000 / the / route of the app has no content on it, so when you log into that page, you see a blank page.

Solution

Check to see if the browser is on /, and if so, redirect to /operator where our content lives.

Breaking changes

No breaking changes for our core code. If anyone has custom packages use the / route, this will break their page and redirect to /operator.

Testing

  1. Login to Reaction Admin
  2. See you are redirected to /operator
  3. Directly type localhost:3000 in the browser
  4. See it redirects to /operator
  5. See other routes work

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit 0cf93e1 into develop Aug 8, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-addRedirectForBlankRoute branch August 13, 2019 17:18
This was referenced Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants